-
Notifications
You must be signed in to change notification settings - Fork 772
Reference Models Centrally, set OpenAI Model to gpt-5-nano and Updated Spec Defaults #4608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v1.15
Are you sure you want to change the base?
Conversation
@giterinhub - Is there a corresponding code issue tracking this that you are aware of? |
Created dapr/components-contrib#3792 |
No issue I'm aware of, just created the PR. Thanks for the good time at the Boom Battle Mark! |
@giterinhub - Can you review this PR now the code is in. In particular can you address
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few comments for this. Thank you for following up with the corresponding docs PR for your changes 🙌 🚀
daprdocs/content/en/reference/components-reference/supported-conversation/openai.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-conversation/openai.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-conversation/openai.md
Outdated
Show resolved
Hide resolved
Thanks @sicoyle ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thank you!
@giterinhub any chance you can correct the DCO step on the PR? If you click in on the build step it has the cmds you can run to make it clean and green :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…tion components Signed-off-by: Erin La <[email protected]>
Signed-off-by: Erin La <[email protected]>
Signed-off-by: Marc Duiker <[email protected]>
…ation links (dapr#4860) Modified multiple Redis-related markdown files to update the links for the Sentinel master name documentation from the old URL to the latest version. This ensures users have access to the most current information regarding Redis Sentinel configuration. Signed-off-by: Mustafa <[email protected]>
…xamples - Add and document runtime env vars: OPENAI_MODEL, AZURE_OPENAI_MODEL, ANTHROPIC_MODEL, GOOGLEAI_MODEL, MISTRAL_MODEL, HUGGINGFACE_MODEL, OLLAMA_MODEL (with defaults) - Update environment reference page with the new env var names and defaults - Replace env-var placeholders in component YAML examples with literal default model names for OpenAI, GoogleAI, Anthropic, Mistral, Hugging Face and Ollama - Add "(configurable via '<ENV>' environment variable)" to each provider's Spec metadata table to show override option - Add Azure OpenAI usage section to `conversation.openai` doc (how to use `apiType: azure` and `AZURE_OPENAI_MODEL`) - Clarify AWS Bedrock uses standard AWS auth (no Bedrock-specific env var added) - Fix small markdown lint issues (trailing newlines/whitespace) Signed-off-by: Erin La <[email protected]>
…onversation/openai.md Co-authored-by: Sam <[email protected]> Signed-off-by: Erin La <[email protected]>
…onversation/openai.md Co-authored-by: Sam <[email protected]> Signed-off-by: Erin La <[email protected]>
…onversation/openai.md Co-authored-by: Sam <[email protected]> Signed-off-by: Erin La <[email protected]>
Signed-off-by: GitHub <[email protected]>
Need to wait on this PR from main to branch dapr/components-contrib#4029 |
When apiType = "azure": Uses AZURE_OPENAI_MODEL environment variable (defaults to "gpt-4.1-nano")
I don't see additional MD file, maybe it was removed.
IMO Bedrock should follow the same pattern and support env variable for model override. Apart from these, this is a great PR (we need a similar PR for API KEY separately. |
Mentioned already that I like to have AZURE_OPENAI_MODEL and OPENAI_MODEL separately @bibryam I had to remove the entry for AZURE_OPENAI_MODEL as Sam wanted it gone ;) |
AZURE_OPENAI_MODEL is not a thing... all components that use the conversation.openai type will just use the env var of OPENAI_MODEL if they choose to use the env var to set their model. There are several components, not just azure that are openai compatible, so we don't want a ton of env vars for each of them. Since they all can just use the openai component, then they can all use the openai env var. Examples include: Minimax, Qwen, Ernie, Azure, etc. Editting to add a few clarifications: There is logic under the hood that checks if apiType is set to azure. In that case, the appropriate Azure model is chosen instead of defaulting to the generic OpenAI model. @bibryam Please create a separate issue if you’d like the API_KEY to also be set via an env var. That said, should all metadata fields be configurable this way? It feels like a lot—so where do we draw the line? Looking back at the contrib PR, it appears we missed Bedrock. This shouldn’t block the current PR and can be added later, but for now, it will be missing. |
Feat: Add new conversation components and update model defaults
This pull request introduces documentation for two new conversation components (GoogleAI and Ollama) and updates the default LLM models for several existing components to newer versions.
A key change is that the default model for each conversation component can now be configured at runtime via a dedicated environment variable.
Summary of Changes:
New Conversation Components:
conversation.googleai
component, which defaults to thegemini-2.5-flash-lite
model.conversation.ollama
component, which defaults to thellama3.2:latest
model.Default Model Updates:
claude-3-5-sonnet-20240620
toclaude-sonnet-4-20250514
.meta-llama/Meta-Llama-3-8B
todeepseek-ai/DeepSeek-R1-Distill-Qwen-32B
.gpt-4-turbo
togpt-5-nano
.open-mistral-7b
.Configuration via Environment Variables:
OPENAI_MODEL
,GOOGLEAI_MODEL
, etc.).ANTHROPIC_MODEL
GOOGLEAI_MODEL
HUGGINGFACE_MODEL
MISTRAL_MODEL
OLLAMA_MODEL
OPENAI_MODEL